Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: 3.1.0 -> 4.0.0 #60133

Merged
merged 3 commits into from
May 21, 2019
Merged

qemu: 3.1.0 -> 4.0.0 #60133

merged 3 commits into from
May 21, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 24, 2019

Motivation for this change

https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03851.html

Middle of rebuild, haven't tried this yet --
hopefully we only need to remove any patches no longer needed
and lots of testing :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra April 24, 2019 01:50
@dtzWill dtzWill marked this pull request as ready for review April 24, 2019 08:41
@alyssais
Copy link
Member

I've successfully built this locally on Darwin fyi

@dtzWill dtzWill requested review from andir and shlevy April 26, 2019 04:03
@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

aarch64 failure unrelated (dependency), this seems good to go from my standpoint. Thoughts?

andir
andir approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Ran a few nixos tests and an Ubuntu 18.04 VM with this branch 👍.

(On NixOS / x86-64)

@ar1a
Copy link
Contributor

ar1a commented May 14, 2019

any update? keen for the new version!

@ghost
Copy link

ghost commented May 20, 2019

Still working on this?
Would love to enjoy the upgrades!

@dtzWill
Copy link
Member Author

dtzWill commented May 20, 2019

LGTM (x86_64 as well), and if no one has any objections I'll merge this later today, if no one beats me to it ;).

@dtzWill dtzWill merged commit 35dea87 into NixOS:staging May 21, 2019
@dtzWill dtzWill deleted the update/qemu-4.0.0 branch May 21, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtzWill @alyssais @ar1a @andir